fix: UnoQ support for I2C priority function #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix compilation failure for UnoQ when both Modulino and Arduino_LED_Matrix libraries are included.
How to reproduce
Modulino 0.6.0arduino:zephyr 0.51.0Example sketch that triggers the error:
Error
Root Cause
Modulino.cpp incorrectly handles the conditional logic for defining __increaseI2CPriority.
When Arduino_LED_Matrix.h is included but ARDUINO_UNOR4_WIFI is not defined (e.g., compiling for UnoQ), neither branch provides a definition for the function, resulting in an undefined reference.
Fix
Ensure that there is always at least one definition of
__increaseI2CPriority. If UnoQ the void definition is added.