Fix/enhance: OPTA socket delay and increasing limits. #1099
+24
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed macOS example from README.md.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on fixing
readSocket()100ms delay by removing an unnecessary wait call, and increasing the socket limits from 4 to 8 for the OPTA variant of the ArduinoCore-mbed. The 8 socket limit was chosen to fit my application, and my test Opta has tolerated the increase.This request targets issues #1067 and #1078.
I only adjusted
libraries/SocketWrapper/src/MbedClient.cppandvariants/OPTA/conf/mbed_app.json, the rest seem to be auto-generated from the compiling.Please let me know if anything needs adjusting.