Update SPI stored setting also in begin() #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: imperfection
per1234
reviewed
Oct 4, 2025
Collaborator
per1234
left a comment
per1234
left a comment
There was a problem hiding this comment.
@Jampag tested this patch and reported on Arduino Forum that it does indeed fix #493:
https://forum.arduino.cc/t/arduino-r4-spi-cambio-velocita/1383392/5
I just checked with an oscilloscope that the frequency remains the set one and no longer 1MHz.
(translated to English)
pennam
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #493.
The SPI settings were not updated in the strange context of the issue because the begin() function did update SPI setting without storing the values into the stored SPI settings (stored SPI settings are used to avoid the update of the settings in case new setting are the same of the ones already used).