Skip to content

Conversation

@lucarin91
Copy link
Contributor

@lucarin91 lucarin91 commented Oct 30, 2025

Motivation

Requires in systemd unit is too strict and ties two much arduino-app-cli wth the arduino-rotuer. So if the router is disabled or stopped, the app-cli daemon will be too. This is not necessary and creates some strange behavior during system updates.

Change description

Removed requires field.

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@per1234 per1234 added the bug Something isn't working label Oct 30, 2025
@lucarin91 lucarin91 marked this pull request as ready for review October 30, 2025 14:06
@lucarin91 lucarin91 requested a review from dido18 November 3, 2025 13:51
@lucarin91
Copy link
Contributor Author

With some test on the board, I verify that the router is not stopping or disabling the app-cli daemon, as expected.

test start/stop of arduino-rotuer

  1. sudo systemctl status arduino-app-cli -> running 🟢
  2. sudo systemctl status arduino-router -> running 🟢
  3. sudo systemctl stop arduino-router
  4. sudo systemctl status arduino-router -> dead 🔴
  5. sudo systemctl status arduino-app-cli -> running 🟢

test enable/disable of arduino-rotuer

  1. sudo systemctl status arduino-app-cli -> enabled 🟢
  2. sudo systemctl status arduino-router -> enabled 🟢
  3. sudo systemctl disable arduino-router
  4. sudo systemctl status arduino-router -> disabled 🟡
  5. sudo systemctl status arduino-app-cli -> enabled 🟢

@lucarin91 lucarin91 requested a review from dido18 November 3, 2025 17:29
@lucarin91 lucarin91 merged commit a6c084e into main Nov 3, 2025
9 checks passed
@lucarin91 lucarin91 deleted the reduce-app-cli-requirement branch November 3, 2025 17:55
mirkoCrobu pushed a commit that referenced this pull request Nov 4, 2025
* fix: remove strong requirements in systemd unit

* trigger ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants