fix: check free disk space and allow to specify a different download/extraction directory #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
previously requested changes
Nov 3, 2025
Co-authored-by: Per Tillisch <accounts@perglass.com>
per1234
dismissed
their stale review
Requested changes have been made. Thanks!
lucarin91
reviewed
Nov 5, 2025
| "github.com/arduino/arduino-flasher-cli/i18n" | ||
| ) | ||
|
|
||
| const GB = uint64(1024 * 1024 * 1024) |
There was a problem hiding this comment.
Suggested change
| const GB = uint64(1024 * 1024 * 1024) | |
| const GiB = uint64(1024 * 1024 * 1024) |
| return nil, err | ||
| } | ||
| if d.Free/GB < NeededDiskSpace { | ||
| return nil, fmt.Errorf("aborting: download and extraction requires up to %d GB of free space", NeededDiskSpace) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("aborting: download and extraction requires up to %d GB of free space", NeededDiskSpace) | |
| return nil, fmt.Errorf("aborting: download and extraction requires up to %d GiB of free space", NeededDiskSpace) |
| if err != nil { | ||
| return nil, fmt.Errorf("could not get user's cache directory: %w", err) | ||
| } | ||
| func GetTempDir(prefix string, tempDir string) (*paths.Path, error) { |
There was a problem hiding this comment.
It is strange, in my opinion, that a function called GetTempDir has a parameter called tempDir. I think we should refactor this to make it cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The default download/extraction directory might be on a disk with insufficient space.
Change description
Two changes have been introduced:
--temp-dirflag;Additional Notes
Reviewer checklist
main.