chore: macOS build security review #2805
Open
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomocusinato
temporarily deployed
to
production
GitHub Actions
Inactive
giacomocusinato
changed the title
giacomocusinato
changed the title
giacomocusinato
temporarily deployed
to
production
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The following changes make IDE 2.x more secure.
Change description
Removed unnecessary environment variable entitlement
The entitlement com.apple.security.cs.allow-dyld-environment-variables has been disabled, as it is not required for normal IDE operation.
Hardened native binary permissions
Theia’s build system bundles native executables with overly permissive file modes (0777) by default (see source).
To mitigate this, the file copy mechanism has been overridden to apply stricter, standard permissions (0755).
Other information
Reviewer checklist