feat: avoid get workgroup #3234
Open
+119
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_workgroup_config to determine if the workgroup config should be retreived from the server
inbar-beehero
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kukushking
reviewed
Nov 5, 2025
| Data Source / Catalog name. If None, 'AwsDataCatalog' will be used by default. | ||
| wait | ||
| Indicates whether to wait for the query to finish and return a dictionary with the query execution response. | ||
| retreive_workgroup_config |
There was a problem hiding this comment.
I think this flag might be redundant. We should let the user override s3_output, encryption, kms key (which we already do), otherwise fall back to default workgroup settings.
There was a problem hiding this comment.
Your suggestion is definitely an option - it just means that we will never get the settings from the AWS API. Personally I'm fine with that, and ready to change the PR to do so, let me know if it's fine
There was a problem hiding this comment.
I created a 2nd PR to this effect: #3237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Allow callers of Athena functions to avoid retrieving the Athena workgroup configuration from the AWS account
Relates
#3233
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.