Windows: Fix unbounded growth of stored scoped attributes #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efs/registry. Fix unbounded growth of scoped attributes stored in PlayerPrefs/registry on Windows. - Maintain a HashSet of keys and serialize back to a compact List to prevent duplicates - Skip PlayerPrefs writes when the new value matches the stored value - Parse + cleanup in CleanScopedAttributes/GetScopedAttributes
…lient - Verifies duplicate keys are not added repeatedly - Confirms PlayerPrefs writes are skipped when value unchanged - Retains backward compatibility with legacy attribute reads
|
|
||
| try | ||
| { | ||
| var attributes = JsonUtility.FromJson<ScopedAttributesContainer>(attributesJson); |
There was a problem hiding this comment.
its our contract, and it should never break.
| try | ||
| { | ||
| var attributes = JsonUtility.FromJson<ScopedAttributesContainer>(attributesJson); | ||
| if (attributes?.Keys != null) |
There was a problem hiding this comment.
if the if statement is invalid, then the catch should capture this. Since this is our contract and we require the people to follow it, why we should check it?
| { | ||
| try | ||
| { | ||
| var container = JsonUtility.FromJson<ScopedAttributesContainer>(attributesJson); |
There was a problem hiding this comment.
why you cannot deserialize array into hashset?
| { | ||
| var container = new ScopedAttributesContainer | ||
| { | ||
| Keys = keys.OrderBy(k => k, StringComparer.Ordinal).ToList() |
There was a problem hiding this comment.
why do you need it? also the same order needs to be applied to values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
What changed
ref: BT-5953