-
Notifications
You must be signed in to change notification settings - Fork 42
Auto Enable A11y fix #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AakashHotchandani
wants to merge
21
commits into
master
Choose a base branch
from
SDK-UNKNOW
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Auto Enable A11y fix #1023
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
d627896
auto enable A11y
AakashHotchandani 83047fc
added logs
AakashHotchandani 2598d30
added api call
AakashHotchandani ab6ac5d
api call change
AakashHotchandani 4bae0c7
fix api
AakashHotchandani 81df849
fixes is core logic
AakashHotchandani cb71291
minor fixes
AakashHotchandani f878c16
minor fix
AakashHotchandani 84945f5
logging added
AakashHotchandani 511a2d1
print response data
AakashHotchandani 4f8b306
minor fix
AakashHotchandani ecb295a
logs change
AakashHotchandani c24df25
added server fixes
AakashHotchandani 9b8e8ea
minor fix
AakashHotchandani bc47259
added logs for server changes
AakashHotchandani 63a651b
fix for validCypressCommands
AakashHotchandani e7b030f
removed ngrok logging
AakashHotchandani dd25780
Merge remote-tracking branch 'origin/master' into SDK-UNKNOW
AakashHotchandani 6c03dde
log changes
AakashHotchandani 8cd4c38
addressed review comments
AakashHotchandani 3743b6e
removed redundant env
AakashHotchandani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,15 @@ | ||
| exports.API_URL = 'https://accessibility.browserstack.com/api'; | ||
|
|
||
| exports.ACCESSIBILITY_ENV_VARS = [ | ||
| "BROWSERSTACK_TEST_ACCESSIBILITY", | ||
| "ACCESSIBILITY_AUTH", | ||
| "ACCESSIBILITY_SCANNERVERSION", | ||
| "ACCESSIBILITY_COMMANDS_TO_WRAP", | ||
| "ACCESSIBILITY_BUILD_END_ONLY", | ||
| "ACCESSIBILITY_EXTENSION_PATH", | ||
| "ACCESSIBILITY_INCLUDETAGSINTESTINGSCOPE", | ||
| "ACCESSIBILITY_EXCLUDETAGSINTESTINGSCOPE", | ||
| "BS_A11Y_JWT", | ||
| "BS_A11Y_TEST_RUN_ID", | ||
| "BROWSERSTACK_ACCESSIBILITY_DEBUG" | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these need to be added at setSystemEnvs, else won't be available in browserstack terminal
Maintain something like OBSERVABILITY_ENV_VARS for a11y as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made the changes