Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 4, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

cmake-rn@0.6.0

Minor Changes

  • 60fae96: Use find_package instead of include to locate "weak-node-api"

Patch Changes

  • 61fff3f: Allow passing --apple-bundle-identifier to specify the bundle identifiers used when creating Apple frameworks.
  • Updated dependencies [60fae96]
  • Updated dependencies [61fff3f]
  • Updated dependencies [61fff3f]
  • Updated dependencies [5dea205]
  • Updated dependencies [60fae96]
  • Updated dependencies [60fae96]
  • Updated dependencies [eca721e]
    • react-native-node-api@0.7.0

gyp-to-cmake@0.5.0

Minor Changes

  • 60fae96: Use find_package instead of include to locate "weak-node-api"

react-native-node-api@0.7.0

Minor Changes

  • 61fff3f: Ensure proper escaping when generating a bundle identifier while creating an Apple framework
  • 60fae96: Use find_package instead of include to locate "weak-node-api"
  • 60fae96: No longer exporting weakNodeApiPath, import from "weak-node-api" instead

Patch Changes

  • 60fae96: Moved weak-node-api into a separate "weak-node-api" package.
  • 61fff3f: Allow passing --apple-bundle-identifier to specify the bundle identifiers used when creating Apple frameworks.
  • 5dea205: Add "apple" folder into the package (follow-up to Move and simplify Apple host TurboModule #301)
  • eca721e: Don't instruct users to pass --force when vendoring hermes
  • Updated dependencies [60fae96]
    • weak-node-api@0.0.2

ferric-cli@0.3.8

Patch Changes

  • 61fff3f: Allow passing --apple-bundle-identifier to specify the bundle identifiers used when creating Apple frameworks.
  • Updated dependencies [60fae96]
  • Updated dependencies [61fff3f]
  • Updated dependencies [61fff3f]
  • Updated dependencies [5dea205]
  • Updated dependencies [60fae96]
  • Updated dependencies [60fae96]
  • Updated dependencies [eca721e]
    • react-native-node-api@0.7.0

weak-node-api@0.0.2

Patch Changes


Note

Publishes react-native-node-api 0.7.0 and related packages, splitting out weak-node-api, switching to find_package, and adding Apple bundle identifier support with framework fixes.

  • Core (react-native-node-api@0.7.0)
    • Split weak-node-api into standalone package (weak-node-api@0.0.2) and stop exporting weakNodeApiPath.
    • Switch to find_package for locating weak-node-api.
    • Apple: add --apple-bundle-identifier, fix bundle identifier escaping, include apple/ folder, and remove --force guidance when vendoring Hermes.
  • Tooling
    • cmake-rn@0.6.0: use find_package for weak-node-api; add --apple-bundle-identifier option; dep bump to react-native-node-api@0.7.0.
    • gyp-to-cmake@0.5.0: use find_package for weak-node-api.
    • ferric-cli@0.3.8: add --apple-bundle-identifier; dep bump to react-native-node-api@0.7.0.
    • node-tests: devDep bump to react-native-node-api@^0.7.0.

Written by Cursor Bugbot for commit 4bc1249. This will update automatically on new commits. Configure here.

@github-actions github-actions bot force-pushed the changeset-release/main branch 5 times, most recently from bd161f3 to c4a9636 Compare November 6, 2025 09:36
@github-actions github-actions bot force-pushed the changeset-release/main branch from c4a9636 to 4bc1249 Compare November 6, 2025 10:13
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bug: Missing Peer Dependency Breaks CMake Find Package

Missing weak-node-api peer dependency. The package now generates CMakeLists.txt files with find_package(weak-node-api REQUIRED CONFIG) according to the CHANGELOG (commit 60fae96), but doesn't declare weak-node-api as a peer dependency. Users who generate CMake configurations with this tool will encounter build failures when CMake cannot find the weak-node-api package.

packages/gyp-to-cmake/package.json#L26-L30

"gyp-parser": "^1.0.4",
"pkg-dir": "^8.0.0",
"read-pkg": "^9.0.1"
}
}

Fix in Cursor Fix in Web


"@react-native-node-api/cli-utils": "0.1.1",
"cmake-file-api": "0.1.0",
"react-native-node-api": "0.6.2",
"react-native-node-api": "0.7.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Peer Dependency Causes CMake Configuration Failures

Missing weak-node-api peer dependency. The package now uses find_package(weak-node-api REQUIRED CONFIG) according to the CHANGELOG (commit 60fae96), but doesn't declare weak-node-api as a peer dependency. Since react-native-node-api only has weak-node-api as a peerDependency (not a regular dependency), users of cmake-rn won't have weak-node-api installed automatically, causing CMake configuration failures when it tries to find the package.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant