feat(c-radio): create package #320
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TylerAPfledderer
force-pushed
the
feat/c-radio
branch
from
5d18525 to
9613902
Compare
There was a problem hiding this comment.
Looks really good @TylerAPfledderer . Requested some few changes
| {...groupApi.value.getRadioLabelProps(radioProps)} | ||
| __css={labelStyles.value} | ||
| > | ||
| {() => getValidChildren(slots)} |
There was a problem hiding this comment.
Let's use {slots.default?.()} here
| const api = computed(() => radio.connect(state.value, send, normalizeProps)) | ||
|
|
||
| return api |
There was a problem hiding this comment.
| const api = computed(() => radio.connect(state.value, send, normalizeProps)) | |
| return api | |
| const return = computed(() => radio.connect(state.value, send, normalizeProps)) |
| import { CRadio, CRadioGroup } from "../../index" | ||
| import * as Examples from "../../examples" | ||
|
|
||
| const runTest = () => { |
| @@ -0,0 +1,3 @@ | |||
| export { CRadioGroup, type CRadioGroupProps } from "./c-radio-group" | |||
| export { CRadio, type CRadioProps } from "./c-radio" | |||
| export type { RadioGroupContext } from "./radio-context" | |||
There was a problem hiding this comment.
Let's keep the C${COMPONENT_NAME}Context naming convention here. Would like all types to be exposed with the C in front of it.
Pull request checklist
Please check if your PR fulfills the following requirements:
/start features)
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Fixes: [ISSUE NUMBER]
What is the new behavior?
Does this introduce a breaking change?
Other information