Enable strict compiler settings #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpkroth
added
in-progress
2 tasks
src/main/java/com/oltpbenchmark/benchmarks/auctionmark/AuctionMarkLoader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/oltpbenchmark/benchmarks/wikipedia/data/RevisionHistograms.java
Show resolved
Hide resolved
src/test/java/com/oltpbenchmark/benchmarks/auctionmark/TestAuctionMarkWorker.java
Show resolved
Hide resolved
(need concrete types for the serialization methods to be resolvable)
bpkroth
commented
Dec 13, 2023
bpkroth
commented
Dec 13, 2023
src/main/java/com/oltpbenchmark/benchmarks/auctionmark/AuctionMarkLoader.java
Show resolved
Hide resolved
bpkroth
added a commit
that referenced
this pull request
Dec 14, 2023
Builds off of #413 to enable the dependency management plugin in non-report mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enforces javac compiler warnings and linting as errors as a part of #406.
Splitting work out from #410, though that should be merged first, and may require additional fixups after that (e.g., new compiler constraints).