Skip to content

Conversation

@jgonzac
Copy link

@jgonzac jgonzac commented Oct 10, 2025

Allow parsing some basic macro statement identifiers

@jgonzac jgonzac self-assigned this Oct 10, 2025
@jgonzac jgonzac requested review from a team, alvrogd and igarcia0 and removed request for a team October 10, 2025 08:47
Copy link

@daniel-otero daniel-otero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case for this change? Otherwise, any new attempt to improve the grammar could fail for the case this is trying to solve.

@inaki-amatria
Copy link
Member

Could you add a test case for this change? Otherwise, any new attempt to improve the grammar could fail for the case this is trying to solve.

It's such a shame, but I think we can't do that here. We have no way to pass in the MacroIdentifiers to tree-sitter test :-(

@jgonzac jgonzac force-pushed the feature/AllowMacroExpressions branch from 1bd5b34 to 813d49d Compare October 13, 2025 07:01
@jgonzac
Copy link
Author

jgonzac commented Oct 13, 2025

Could you add a test case for this change? Otherwise, any new attempt to improve the grammar could fail for the case this is trying to solve.

Iñaki is right, we can't do it here. Although I added a test case in the other side checking the grammar tree output.

Copy link
Member

@inaki-amatria inaki-amatria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jgonzac jgonzac merged commit 813d49d into codee Oct 13, 2025
1 check passed
@jgonzac jgonzac deleted the feature/AllowMacroExpressions branch October 13, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants