Skip to content

refactor: set registry default value in shell #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: set registry default value in shell #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,7 @@ jobs:
build:
# The type of runner that the job will run on
runs-on: ubuntu-latest

# TODO hard code, because GitHub Actions only support secrets but not env
env:
CODING_GENERIC_REGISTRY: https://coding-public-generic.pkg.coding.net/public/downloads/


# Steps represent a sequence of tasks that will be executed as part of the job
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
Expand Down
6 changes: 4 additions & 2 deletions coding-generic-sync.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@
set -e

if [ "$CODING_GENERIC_REGISTRY" = "" ]; then
echo "WARNING: env CODING_GENERIC_REGISTRY not set, only run download"
elif [ "$CODING_ARTIFACTS_USERNAME" = "" ]; then
echo "WARNING: env CODING_GENERIC_REGISTRY not set, use default value"
CODING_GENERIC_REGISTRY="https://coding-public-generic.pkg.coding.net/public/downloads/"
fi
if [ "$CODING_ARTIFACTS_USERNAME" = "" ]; then
echo "WARNING: env CODING_ARTIFACTS_USERNAME not set, only run check and download"
fi

Expand Down