Skip to content

Conversation

@spinto
Copy link

@spinto spinto commented Oct 29, 2025

Apptainer will replace the ':' character with an '_' when the image is pulled during pre-pull, not a '/'.

In fact, '_latest' is correctly added if a ':' is not present. I am not sure what is the reason for the '/' replacement, as '/' is not allowed at all in the docker image name+tag.

This pull fixes the replacement of the ':' character.

Apptainer will replace the ':' character with an '_'
@mr-c
Copy link
Member

mr-c commented Oct 29, 2025

What does singularity do in recent versions? If it is something different, then we'll need an apptainer specific fix

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.61%. Comparing base (72051e2) to head (6d553ee).

Files with missing lines Patch % Lines
cwltool/singularity.py 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (72051e2) and HEAD (6d553ee). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (72051e2) HEAD (6d553ee)
18 12
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2171      +/-   ##
==========================================
- Coverage   85.18%   77.61%   -7.58%     
==========================================
  Files          46       46              
  Lines        8332     8332              
  Branches     1954     1954              
==========================================
- Hits         7098     6467     -631     
- Misses        768     1346     +578     
- Partials      466      519      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spinto
Copy link
Author

spinto commented Oct 30, 2025

@mr-c I have just tested with the latest SingularityCE, and it also replaces the ':' with '_'
image

@mr-c
Copy link
Member

mr-c commented Oct 30, 2025

Okay, now we need to figure out which versions of singularity & apptainer have which behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants