Skip to content

Conversation

@codomposer
Copy link

@codomposer codomposer commented Nov 4, 2025

Description

This pull request addresses several bug fixes and enhancements to improve code quality, functionality, and user experience in the CoreUI Free Bootstrap Admin Template.

Changes Made

🐛 Bug Fixes

1. Fix Typo in package.json

  • Issue: Fixed double 'h' typo in funding URL
  • Change: hhttps://coreui.io/pricing/?framework=bootstraphttps://coreui.io/pricing/?framework=bootstrap

2. Remove Deprecated Chart.js Property

  • Issue: Removed deprecated Chart.defaults.defaultFontColor property which was removed in Chart.js v3+
  • Impact: The project uses Chart.js v4.5.0, so this property had no effect and was causing unnecessary code bloat
  • Note: Font colors are already properly controlled through individual chart configuration options via ticks.color in the ColorSchemeChange event listener

3. Fix Logic Error in Color Mode Detection

  • Issue: Fixed incorrect logical operator in theme preference detection
  • Change: if (storedTheme !== 'light' || storedTheme !== 'dark')if (storedTheme !== 'light' && storedTheme !== 'dark')
  • Impact: The original condition was always true (a value cannot be both 'light' AND 'dark' simultaneously), which prevented proper auto theme switching based on system preferences

🧹 Code Cleanup

4. Remove Empty Script Tags

  • Change: Removed unnecessary empty script tags at the end of HTML files
  • Impact: Cleaner, more maintainable code

✨ Enhancements

5. Add Loading States to Form Buttons

  • Feature: Implemented loading states for Login and Create Account buttons
  • Implementation:
    • Added Bootstrap spinner component to buttons
    • Button text changes during loading (e.g., "Login" → "Logging in...")
    • Buttons are disabled during loading to prevent double submissions
    • Includes demo functionality with 2-second timeout (can be replaced with actual API calls in production)
  • Benefits:
    • Better user experience with visual feedback
    • Prevents accidental double-clicks
    • Accessible with proper ARIA attributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant