Skip to content

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Mar 4, 2025

Proposed changes

according to https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue#triggering-merge-group-checks-with-github-actions

and setting up activating a new ruleset for merge groups, as documented: https://github.com/db-ux-design-system/core-web/settings/rules/3944111

We should additionally have a look at https://github.com/googleapis/release-please as well. we've integrated changesets for release CHANGELOG management.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/feat-added-merge-groups

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Mar 4, 2025
@mfranzke mfranzke self-assigned this Mar 4, 2025
@github-actions github-actions bot added the 🚢📀cicd Changes inside .github folder label Mar 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/feat-added-merge-groups

@mfranzke mfranzke moved this to 🕋 In progress in UX Engineering Team Backlog Mar 5, 2025
@mfranzke mfranzke requested a review from Copilot March 28, 2025 14:37

This comment was marked as outdated.

@mfranzke mfranzke requested a review from Copilot July 21, 2025 16:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds GitHub merge group support to CI/CD workflows to enable merge queue functionality. The changes configure workflows to trigger on merge group events in addition to existing pull request triggers, supporting GitHub's merge queue feature for better branch protection.

  • Adds merge_group triggers to three GitHub Actions workflow files
  • Configures merge group events to target the "main" branch consistently
  • Enables CI checks to run on merge groups as documented in GitHub's merge queue guidance

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/pull-request.yml Added merge group trigger for main branch
.github/workflows/pull-request-opened.yml Added merge group trigger for main branch
.github/workflows/default.yml Added merge group trigger without branch specification


on:
pull_request:
merge_group:
Copy link

Copilot AI Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge_group trigger should specify branches for consistency with the other workflow files. Consider adding 'branches: ["main"]' to match the pattern used in pull-request.yml and pull-request-opened.yml.

Suggested change
merge_group:
merge_group:
branches:
- "main"

Copilot uses AI. Check for mistakes.
@mfranzke mfranzke moved this from 🕋 In progress to 🏗 In development in UX Engineering Team Backlog Sep 29, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2025

⚠️ No Changeset found

Latest commit: 264431d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚢📀cicd Changes inside .github folder 🍄🆙improvement New feature or request

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

2 participants