Skip to content

DBNotification: Add default ARIA role attributes for accessibility #4815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

DBNotification: Add default ARIA role attributes for accessibility #4815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b8b6fc5
Initial plan
Copilot Aug 20, 2025
6271418
Changes before error encountered
Copilot Aug 20, 2025
5ade4a3
Merge branch 'main' into copilot/fix-4206
michaelmkraus Aug 25, 2025
1385671
Merge branch 'main' into copilot/fix-4206
mfranzke Aug 26, 2025
de85044
Merge branch 'main' into copilot/fix-4206
mfranzke Sep 28, 2025
2e5fd19
auto update snapshots (#5078)
github-actions[bot] Sep 28, 2025
4aee532
Merge branch 'main' into copilot/fix-4206
mfranzke Oct 16, 2025
188c514
Merge branch 'main' into copilot/fix-4206
michaelmkraus Oct 29, 2025
cd2b68f
auto update snapshots (#5390)
github-actions[bot] Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ontrast/should-have-same-aria-snapshot/DBNotification-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@
- article:
- text: Headline
- paragraph: Neutral
- article:
- alert:
- text: Headline
- paragraph: Critical
- article:
- status:
- text: Headline
- paragraph: Informational
- article:
- status:
- text: Headline
- paragraph: Successful
- article:
- alert:
- text: Headline
- paragraph: Warning
- link "Closeable"
Expand Down
8 changes: 4 additions & 4 deletions ...hromium/should-have-same-aria-snapshot/DBNotification-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@
- article:
- text: Headline
- paragraph: Neutral
- article:
- alert:
- text: Headline
- paragraph: Critical
- article:
- status:
- text: Headline
- paragraph: Informational
- article:
- status:
- text: Headline
- paragraph: Successful
- article:
- alert:
- text: Headline
- paragraph: Warning
- link "Closeable"
Expand Down
8 changes: 4 additions & 4 deletions ...firefox/should-have-same-aria-snapshot/DBNotification-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@
- article:
- text: Headline
- paragraph: Neutral
- article:
- alert:
- text: Headline
- paragraph: Critical
- article:
- status:
- text: Headline
- paragraph: Informational
- article:
- status:
- text: Headline
- paragraph: Successful
- article:
- alert:
- text: Headline
- paragraph: Warning
- link "Closeable"
Expand Down
8 changes: 4 additions & 4 deletions ...-chrome/should-have-same-aria-snapshot/DBNotification-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@
- article:
- text: Headline
- paragraph: Neutral
- article:
- alert:
- text: Headline
- paragraph: Critical
- article:
- status:
- text: Headline
- paragraph: Informational
- article:
- status:
- text: Headline
- paragraph: Successful
- article:
- alert:
- text: Headline
- paragraph: Warning
- link "Closeable"
Expand Down
8 changes: 4 additions & 4 deletions ...-safari/should-have-same-aria-snapshot/DBNotification-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@
- article:
- text: Headline
- paragraph: Neutral
- article:
- alert:
- text: Headline
- paragraph: Critical
- article:
- status:
- text: Headline
- paragraph: Informational
- article:
- status:
- text: Headline
- paragraph: Successful
- article:
- alert:
- text: Headline
- paragraph: Warning
- link "Closeable"
Expand Down
8 changes: 4 additions & 4 deletions .../webkit/should-have-same-aria-snapshot/DBNotification-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@
- article:
- text: Headline
- paragraph: Neutral
- article:
- alert:
- text: Headline
- paragraph: Critical
- article:
- status:
- text: Headline
- paragraph: Informational
- article:
- status:
- text: Headline
- paragraph: Successful
- article:
- alert:
- text: Headline
- paragraph: Warning
- link "Closeable"
Expand Down
2 changes: 2 additions & 0 deletions packages/components/src/components/notification/notification.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
cls,
getBoolean,
getBooleanAsString,
getNotificationRole,
stringPropVisible
} from '../../utils';
import DBButton from '../button/button.lite';
Expand Down Expand Up @@ -41,6 +42,7 @@ export default function DBNotification(props: DBNotificationProps) {
ref={_ref}
id={props.id}
class={cls('db-notification', props.className)}
role={getNotificationRole(props.semantic)}
aria-live={props.ariaLive}
data-semantic={props.semantic}
data-variant={props.variant}
Expand Down
18 changes: 18 additions & 0 deletions packages/components/src/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,21 @@ export const isKeyboardEvent = <T>(
event?: ClickEvent<T> | GeneralKeyboardEvent<T>
): event is GeneralKeyboardEvent<T> =>
(event as GeneralKeyboardEvent<T>).key !== undefined;

/**
* Maps semantic values to appropriate ARIA roles for notifications
* @param semantic - The semantic type of the notification
* @returns The appropriate ARIA role or undefined for default behavior
*/
export const getNotificationRole = (semantic?: string): string | undefined => {
switch (semantic) {
case 'critical':
case 'warning':
return 'alert';
case 'informational':
case 'successful':
return 'status';
default:
return undefined;
}
};
Loading