Skip to content

docs(svg-img-alt): add missing role attribute for svgs #4927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+8 −8
Open

docs(svg-img-alt): add missing role attribute for svgs #4927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions test/checks/shared/svg-non-empty-title.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,56 +13,56 @@ describe('svg-non-empty-title tests', function () {

it('returns true if the element has a `title` child', function () {
var checkArgs = checkSetup(
'<svg id="target"><title>Time II: Party</title></svg>'
'<svg id="target" role="img"><title>Time II: Party</title></svg>'
);
assert.isTrue(checkEvaluate.apply(checkContext, checkArgs));
});

it('returns true if the `title` child has text nested in another element', function () {
var checkArgs = checkSetup(
'<svg id="target"><title><g>Time II: Party</g></title></svg>'
'<svg id="target" role="img"><title><g>Time II: Party</g></title></svg>'
);
assert.isTrue(checkEvaluate.apply(checkContext, checkArgs));
});

it('returns true if the element has a `title` child with `display:none`', function () {
var checkArgs = checkSetup(
'<svg id="target"><title style="display: none;">Time II: Party</title></svg>'
'<svg id="target" role="img"><title style="display: none;">Time II: Party</title></svg>'
);
assert.isTrue(checkEvaluate.apply(checkContext, checkArgs));
});

it('returns false if the element has no `title` child', function () {
var checkArgs = checkSetup('<svg id="target"></svg>');
var checkArgs = checkSetup('<svg id="target" role="img"></svg>');
assert.isFalse(checkEvaluate.apply(checkContext, checkArgs));
assert.equal(checkContext._data.messageKey, 'noTitle');
});

it('returns false if the `title` child is empty', function () {
var checkArgs = checkSetup('<svg id="target"><title></title></svg>');
var checkArgs = checkSetup('<svg id="target" role="img"><title></title></svg>');
assert.isFalse(checkEvaluate.apply(checkContext, checkArgs));
assert.equal(checkContext._data.messageKey, 'emptyTitle');
});

it('returns false if the `title` is a grandchild', function () {
var checkArgs = checkSetup(
'<svg id="target"><circle><title>Time II: Party</title></circle></svg>'
'<svg id="target" role="img"><circle><title>Time II: Party</title></circle></svg>'
);
assert.isFalse(checkEvaluate.apply(checkContext, checkArgs));
assert.equal(checkContext._data.messageKey, 'noTitle');
});

it('returns false if the `title` child has only whitespace', function () {
var checkArgs = checkSetup(
'<svg id="target"><title> \t\r\n </title></svg>'
'<svg id="target" role="img"><title> \t\r\n </title></svg>'
);
assert.isFalse(checkEvaluate.apply(checkContext, checkArgs));
assert.equal(checkContext._data.messageKey, 'emptyTitle');
});

it('returns false if there are multiple titles, and the first is empty', function () {
var checkArgs = checkSetup(
'<svg id="target"><title></title><title>Time II: Party</title></svg>'
'<svg id="target" role="img"><title></title><title>Time II: Party</title></svg>'
);
assert.isFalse(checkEvaluate.apply(checkContext, checkArgs));
assert.equal(checkContext._data.messageKey, 'emptyTitle');
Expand Down