Fix HttpSys test failure on non-Windows platforms. #64180
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medhatiwari
requested review from
BrennanConroy,
JamesNK and
halter73
as code owners
github-actions
bot
added
the
area-networking
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Thanks for your PR, @@medhatiwari. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
dotnet-policy-service
bot
added
the
pending-ci-rerun
Member
|
Can you point to where you saw this failing in CI? The entire assembly is marked as skip on macOS and Linux, so while I think this change is fine for consistency, I don't think it should be required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix HttpSys test failure on non-Windows platforms.
Issue
CI observed failure in
Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.RequestTests.Latin1UrlIsRejectedon Linux.Test fails with
EntryPointNotFoundException: HttpInitializebecause HttpSys is Windows-only.Fix
Change
[Fact]to[ConditionalFact]to align with other HttpSys tests that properly skip on non-Windows platforms.cc: @giritrivedi