-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Document breaking change: Double quotes disallowed in file-level directives #49608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ectives Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
docs/core/compatibility/sdk/10.0/file-level-directive-double-quotes.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/sdk/10.0/file-level-directive-double-quotes.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/sdk/10.0/file-level-directive-double-quotes.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/sdk/10.0/file-level-directive-double-quotes.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/sdk/10.0/file-level-directive-double-quotes.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/sdk/10.0/file-level-directive-double-quotes.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/sdk/10.0/file-level-directive-double-quotes.md
Outdated
Show resolved
Hide resolved
docs/core/compatibility/sdk/10.0/file-level-directive-double-quotes.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation for a breaking change in .NET 10 GA where double quotes are disallowed in file-level directives (#:) for file-based apps. The change prevents potentially confusing behavior and prepares for future support of quoted directives.
Key Changes
- Adds new breaking change documentation for double quote restrictions in file-level directives.
- Updates the TOC and summary page to include the new breaking change entry.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
docs/core/compatibility/sdk/10.0/file-level-directive-double-quotes.md |
New breaking change documentation describing the double quote restriction in file-level directives |
docs/core/compatibility/toc.yml |
Adds TOC entry for the new breaking change document |
docs/core/compatibility/10.0.md |
Adds table entry linking to the new breaking change |
.NET 10 GA now errors when double quotes appear in
#:file-level directives for file-based apps. Previously, quotes were silently escaped to"when passed to MSBuild, which didn't provide the expected behavior.Changes
docs/core/compatibility/sdk/10.0/file-level-directive-double-quotes.md#:property,#:sdk,#:package, and#:projectdirectivesDirectory.Build.propsor convert to full project viadotnet project convertExample
Fixes #496360
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Internal previews