Empty parameters are being converted to empty arrays #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no
$modifierwas passed to the function, malformed classes were generated because the empty parameter was converted to an empty array. This empty array always satisfied theissetandis_arrayconditions for theforeachloops that concatenate the$base_classand$blocknameto the modifier.I added a check before the
$modifiervalue is converted to an array to prevent an empty array from being generated.I went ahead and added a check on the
$extraparameter as well, even though it does not present the same issue as it lacks a concatenation when it is being generated.I also removed the lower
is_arraychecks because by that point, if the parameter value is set it is an array.