Skip to content

Update install.sh to support Pop!_OS #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update install.sh to support Pop!_OS #1809

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
746ecb7
Update install.sh to support PopOS
willmartian Aug 17, 2025
853635f
Merge pull request #1 from willmartian/willmartian-patch-1
willmartian Oct 30, 2025
045084f
Merge branch 'elixir-lang:main' into main
willmartian Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ install_otp_linux() {
esac

id=$(grep '^ID=' /etc/os-release | cut -d '=' -f 2)
if [ "${id}" != ubuntu ]; then
if [[ "${id}" != ubuntu || "${id}" != pop ]]; then
Copy link
Member

@josevalim josevalim Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please test this version?

Suggested change
if [[ "${id}" != ubuntu || "${id}" != pop ]]; then
if [ "${id}" != ubuntu ] && [ "${id}" != pop ]; then

We should fail if both do not match (the current version seems to support everything). And we should stick with sh instead of bash. Thanks!

echo $id is not supported
exit 1
fi
Expand Down