-
Notifications
You must be signed in to change notification settings - Fork 433
Fix repeated description #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis PR corrects documentation text in the table of contents file. Two comparison card descriptions that incorrectly referenced "tRPC" now properly reference the correct source frameworks: "Express" and "Hono" respectively. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/table-of-content.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/table-of-content.md
82-82: Hard tabs
Column: 1
(MD010, no-hard-tabs)
83-83: Hard tabs
Column: 1
(MD010, no-hard-tabs)
85-85: Hard tabs
Column: 3
(MD010, no-hard-tabs)
88-88: Hard tabs
Column: 3
(MD010, no-hard-tabs)
🔇 Additional comments (1)
docs/table-of-content.md (1)
81-89: Correct fixes for repeated descriptions.The changes properly correct the duplicated "tRPC" descriptions in the "From Express" and "From Hono" comparison cards. Lines 82 and 88 now accurately reflect their respective source frameworks.
| <Deck> | ||
| <Card title="From Express" href="/migrate/from-express"> | ||
| Comparison between tRPC and Elysia | ||
| Comparison between Express and Elysia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace hard tabs with spaces.
Markdownlint flags hard tabs (MD010) at these locations. For consistency with markdown linting standards and to ensure proper rendering across environments, replace the tabs with spaces.
Also applies to: 83-83, 85-85, 88-88
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
82-82: Hard tabs
Column: 1
(MD010, no-hard-tabs)
🤖 Prompt for AI Agents
In docs/table-of-content.md around lines 82, 83, 85 and 88, replace all hard tab
characters with spaces to satisfy MD010: convert each tab to spaces while
preserving existing indentation and alignment (use a consistent width, e.g., 2
or 4 spaces per tab across the file), save the file and re-run markdownlint to
confirm the warnings are resolved.
I've noticed that in the "From other frameworks?" section of each comparison card, multiple descriptions are repeated.
Summary by CodeRabbit
Documentation