Skip to content

Fix WebAssembly global exports with DECLARE_ASM_MODULE_EXPORTS=0(issue #25556) #25609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix WebAssembly global exports with DECLARE_ASM_MODULE_EXPORTS=0(issue #25556) #25609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4c29da
fix #25556
devalgupta404 Oct 21, 2025
d09a204
removed @no_omit_asm_module_exports
devalgupta404 Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/lib/libcore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1632,16 +1632,13 @@ addToLibrary({
dynCalls[name.substr(8)] = exportedSymbol;
}
#endif
// Globals are currently statically enumerated into the output JS.
// TODO: If the number of Globals grows large, consider giving them a
// similar DECLARE_ASM_MODULE_EXPORTS = 0 treatment.
if (typeof exportedSymbol.value === 'undefined') {
// Export all symbols (both functions and globals) to the global scope
// when DECLARE_ASM_MODULE_EXPORTS=0
#if MINIMAL_RUNTIME
globalThis[name] = exportedSymbol;
globalThis[name] = exportedSymbol;
#else
globalThis[name] = Module[name] = exportedSymbol;
globalThis[name] = Module[name] = exportedSymbol;
#endif
}
}
exportAliases(wasmExports);
},
Expand Down
1 change: 0 additions & 1 deletion test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9711,7 +9711,6 @@ def test_externref_emjs(self, dynlink):
'dylink': [True],
})
@no_esm_integration('https://github.com/emscripten-core/emscripten/issues/25543')
@no_omit_asm_module_exports('https://github.com/emscripten-core/emscripten/issues/25556')
def test_wasm_global(self, dynlink):
if '-flto' in self.cflags or '-flto=thin' in self.cflags:
self.skipTest('https://github.com/emscripten-core/emscripten/issues/25555')
Expand Down