Skip to content

Conversation

@ulgens
Copy link
Contributor

@ulgens ulgens commented Nov 2, 2025

Resolves #9809

@ulgens ulgens marked this pull request as draft November 2, 2025 11:11
It was defined in testenv.deps for tox, which makes it a literal testing requirement
The version requirement is copied from pyproject.toml
These filters are already applied by GenericAPIView.filter_queryset()
@ulgens ulgens force-pushed the fix-cursor-pagination-ordering branch 2 times, most recently from 0053ad4 to a8b6130 Compare November 4, 2025 12:11
@ulgens ulgens force-pushed the fix-cursor-pagination-ordering branch from a8b6130 to e03bd60 Compare November 5, 2025 13:34
@auvipy auvipy added this to the 3.17 milestone Nov 5, 2025
Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be it would be better, if you link other relevant or somewhat relevant issues in the description

@ulgens
Copy link
Contributor Author

ulgens commented Nov 7, 2025

@auvipy I will do, but the PR needs some more serious work. It turned out, our cursor implementation makes heavy usage of "detect ordering from the view config & request" logic while completely ignoring the ordering provided by queryset or any other 3rd party, which makes it significantly harder to customize. I'm afraid the appropriate fix will need a partial rewrite of the cursor mechanism.

@browniebroke
Copy link
Collaborator

browniebroke commented Nov 7, 2025

the PR needs some more serious work. It turned out, our cursor implementation makes heavy usage of "detect ordering from the view config & request" logic while completely ignoring the ordering provided by queryset or any other 3rd party, which makes it significantly harder to customize. I'm afraid the appropriate fix will need a partial rewrite of the cursor mechanism.

Ok that's good to know. With what you learned trying this implementation/fix, do you feel like our docs are explaining this limitation well enough? If not, should we add a note/warning outlining it better? From what you wrote, it feels to me like a proper fix will take longer

@ulgens
Copy link
Contributor Author

ulgens commented Nov 7, 2025

do you feel like our docs are explaining this limitation well enough?

I'm not sure if we want to mention 3rd parties in that part of the docs but I think it would be better if something about django-filters ordering - CursorPagination incompatability mentioned in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants