adding django6.0b1 support #9819
Conversation
|
Removing |
|
@auvipy please review this PR ! |
auvipy
requested review from
auvipy and
Copilot
and removed request for
auvipy
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Django 6.0 beta testing and fixes compatibility issues with Django 6.0 changes. The key changes are:
- Adding Django 6.0 beta to the test matrix for Python 3.12 and 3.13
- Fixing a test compatibility issue with Django 6.0's
values_list()behavior - Adjusting a URL validation test for changes in Django's URL handling
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tox.ini | Adds Django 6.0 beta (6.0b1) to the test environment matrix for py312 and py313 |
| tests/test_validators.py | Fixes values_list() call to explicitly specify 'id' field for Django 6.0 compatibility |
| tests/test_templatetags.py | Adds URLIZE_ASSUME_HTTPS=True setting and removes a URL test case incompatible with Django 6.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "asdf.com", | ||
| "asdf.net", | ||
| "www.as_df.org", | ||
| "as.d8f.ghj8.gov", |
There was a problem hiding this comment.
can you try to fix it without removing it?
There was a problem hiding this comment.
@auvipy This is basically handled by django urlize function. This is good for django 5.2 but It throws error for django-main branch.
There was a problem hiding this comment.
can you check why that fails? and find a way to work on both 5.2 and 6.0? without removing the dot gov domain
There was a problem hiding this comment.
I did make some changes. and also created a tickets in django. link : https://code.djangoproject.com/ticket/36710
There was a problem hiding this comment.
3 participants
No description provided.