Fix overflowing issues in callouts #229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
recheck |
Contributor
Author
|
Can you also review this pull request @filmaj? |
Contributor
|
I'm not a CSS expert so I don't feel confident reviewing this one, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callouts overflows the screen on mobile screens. The main cause of this issue is the long code blocks in callouts. I fix the issue by giving a
min-width: 0property to the contentdivof the callout. Because thatdivis a flex item andmin-width: autoby default, the min width of thedivis themin-contentwithout breaking any text. When we givemin-width: 0, the element correctly shrinks and a scroll-bar appears for the code content. Also now the inline code can correctly wraps to the next line.Before: (The callout content overflows)
After: (The overflowling issue is solved with
min-widthproperty)