Update Network list to use x-fb-friendly-name header #221
+73
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhancement to the Network panel list to check for the
x-fb-friendly-name(Relay) header in response or request headers, and substitute this for the request display name if present.Note: Considered the alternative approach of adding/preconfiguring dedicated columns, simply routing to the named header (existing feature). However, this won't nicely merge both req and response headers. Replacing
nameis both more simple and more seamless.Test plan
With local change in RNTester.
Upstreaming plan
devtools-frontendrepo following the contribution guide for Meta employees OR contribution guide.