Skip to content

Fix "TS2304: Cannot find name 'ToastType'." error in TS definitions + make message optional when updating #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix "TS2304: Cannot find name 'ToastType'." error in TS definitions + make message optional when updating #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9562a4b
Fix "TS2304: Cannot find name 'ToastType'." error in TS definitions
benhodgson87 Nov 13, 2018
b62f753
Message should not be required when updating a toast
benhodgson87 Nov 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/definitions.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import {ToastType, ToastContainerProps as ReactToastContainerProps} from "react-toastify";
import {ToastContainerProps as ReactToastContainerProps} from "react-toastify";
import {ComponentClass, SFC} from "react";

export interface ToastBaseOptions {
Expand All @@ -20,7 +20,7 @@ export interface ToastBaseOptions {
* Set the toast type.
* `One of: 'info', 'success', 'warning', 'error', 'default'`
*/
type?: ToastType;
type?: 'info' | 'success' | 'warning' | 'error' | 'default';

/**
* Pause the timer when the mouse hover the toast.
Expand Down Expand Up @@ -152,7 +152,7 @@ export interface DismissActionPayload {
* Update action options
*/
export interface UpdateActionOptions extends ToastBaseOptions {
message: any;
message?: any;
}

/**
Expand Down