Skip to content

refactor: expander print view #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: expander print view #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2edb4f5
fix: removed arrow-icon from expander in print view
therobrob Nov 3, 2025
3da0111
refactor: expander-behaviour in print-view
therobrob Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 34 additions & 35 deletions assets/sass/expander.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,23 @@
}
}
}

> .material-symbols-rounded {
transition: transform 0.2s;

@media print {
display: none;
}
}

> div {
display: flex;
align-items: center;
gap: 0.5rem;
}
}

.details-screen[open] > .o-expander__summary {
details[open] > .o-expander__summary {
&:hover,
&:focus {
border-radius: var(--border-radius-m) var(--border-radius-m) 0 0;
Expand All @@ -62,10 +76,6 @@
}
}

.details-print {
display: none;
}

details {
position: relative;
background-color: var(--bg-neutral);
Expand All @@ -76,46 +86,35 @@ details {
width: 100%;
margin-left: 0;
}
}

details > summary {
list-style-type: none;
}
> summary {
list-style-type: none;
}

details > div {
overflow-x: auto;
}
> div {
overflow-x: auto;
}

details > summary::-webkit-details-marker {
display: none;
}
> summary::-webkit-details-marker {
display: none;
}

.o-expander__summary > span {
transition: transform 0.2s;
}
@media print {
border: 0.2rem solid #bbb;
page-break-inside: avoid;
display: block;

.o-expander__summary > div {
display: flex;
align-items: center;
gap: 0.5rem;
&::details-content {
content-visibility: visible;
height: auto !important;
}
}
}

.details-screen[open] > .o-expander__summary > span {
details[open] > .o-expander__summary > .material-symbols-rounded {
transform: rotate(180deg);
}

details[open] > .o-expander__summary:not(.o-expander__summary--booking) {
font-weight: 700;
}

@media print {
.details-screen {
display: none;
}

.details-print {
border: 0.2rem solid #bbb;
page-break-inside: avoid;
display: block;
}
}
6 changes: 1 addition & 5 deletions layouts/shortcodes/booking.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
-}}


<details class="details-screen o-expander o-expander--booking">
{{- partial "booking" $params -}}
</details>

<details open class="details-print o-expander o-expander--booking">
<details class="o-expander o-expander--booking">
{{- partial "booking" $params -}}
</details>
17 changes: 1 addition & 16 deletions layouts/shortcodes/expander.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{ $iconMapping := dict "border" "share_location" "traincategory" "train" "info" "info" }}


<details name="{{ (.Get 2) }}" class="details-screen o-expander">
<details name="{{ (.Get 2) }}" class="o-expander">
<summary class="o-expander__summary">
<div>
{{- partial "icon" (index $iconMapping $param) -}}
Expand All @@ -15,18 +15,3 @@
{{ .Inner }}
</div>
</details>

<!--
Workaround for print version, otherwise the expanders would be closed.
The workaround can be removed when the following issue is implemented:
https://github.com/w3c/csswg-drafts/issues/2084
-->
<details open class="details-print o-expander">
<summary class="o-expander__summary">
<span class="o-expander__summary-text">{{ (.Get 0) }}</span>
</summary>
<hr aria-hidden="true" />
<div class="o-expander__content">
{{ .Inner }}
</div>
</details>
Loading