Skip to content

Conversation

@taeold
Copy link
Contributor

@taeold taeold commented Nov 5, 2025

We restore 'typesVersions' in package.json to support TypeScript projects using 'moduleResolution: node'.

This legacy resolution mode ignores the 'exports' field, causing compilation errors when importing subpaths like 'firebase-functions/https'. Restoring 'typesVersions' ensures compatibility for users who haven't migrated to 'node16' or 'nodenext' resolution.

Unblocks firebase/functions-samples#1227.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reintroduces the 'typesVersions' field in the 'package.json' file. This change is essential for maintaining compatibility with TypeScript projects that use the 'moduleResolution: node' setting. By explicitly mapping type definitions for various subpaths, it resolves compilation errors that occur when the 'exports' field is ignored by this legacy resolution mode. This ensures that users who have not yet upgraded to 'node16' or 'nodenext' module resolution can continue to compile their projects without issues.

Highlights

  • TypeScript Compatibility: Restores the 'typesVersions' field in 'package.json' to resolve TypeScript compilation errors for projects configured with 'moduleResolution: node'.
  • Legacy Module Resolution Support: Ensures continued compatibility for users who have not yet migrated their TypeScript projects to 'node16' or 'nodenext' module resolution strategies.
  • Subpath Import Resolution: Addresses issues where the 'exports' field was ignored by the 'node' module resolution, preventing compilation errors when importing subpaths like 'firebase-functions/https'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restores the typesVersions field in package.json to ensure compatibility with legacy TypeScript module resolution (node). The change correctly adds the necessary type mappings for various subpaths, which should resolve the compilation errors for users on older setups. My review includes a couple of suggestions to improve the consistency and maintainability of the newly added configuration block.

@taeold taeold force-pushed the dl-restore-typeversions branch from 970ea0c to 3ca48de Compare November 5, 2025 22:32
We restore 'typesVersions' in package.json to support TypeScript projects using 'moduleResolution: node'.

This legacy resolution mode ignores the 'exports' field, causing compilation errors when importing subpaths like 'firebase-functions/https'. Restoring 'typesVersions' ensures compatibility for users who haven't migrated to 'node16' or 'nodenext' resolution.

Unblocks firebase/functions-samples#1227.
@taeold taeold force-pushed the dl-restore-typeversions branch from 3ca48de to 413bb05 Compare November 5, 2025 22:35
@taeold taeold added this pull request to the merge queue Nov 5, 2025
Merged via the queue into master with commit 92bc127 Nov 5, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants