Add missing expressions

Firestore/Swift/Source/ExpressionImplementation.swift

@@ -523,6 +523,14 @@ public extension Expression {
     return FunctionExpression(functionName: "array_get", args: [self, offsetExpression])
   }
 
+  func arrayMaximum() -> FunctionExpression {
+    return FunctionExpression(functionName: "maximum", args: [self])
+  }
+
+  func arrayMinimum() -> FunctionExpression {
+    return FunctionExpression(functionName: "minimum", args: [self])
+  }
+
   func greaterThan(_ other: Expression) -> BooleanExpression {
     return BooleanExpression(functionName: "greater_than", args: [self, other])
   }
@@ -622,6 +630,14 @@ public extension Expression {
     return FunctionExpression(functionName: "join", args: [self, Constant(delimiter)])
   }
 
+  func split(delimiter: String) -> FunctionExpression {
+    return FunctionExpression(functionName: "split", args: [self, Constant(delimiter)])
+  }
+
+  func split(delimiter: Expression) -> FunctionExpression {
+    return FunctionExpression(functionName: "split", args: [self, delimiter])
+  }
+
   func length() -> FunctionExpression {
     return FunctionExpression(functionName: "length", args: [self])
   }
@@ -709,6 +725,10 @@ public extension Expression {
     return FunctionExpression(functionName: "trim", args: [self, value])
   }
 
+  func trim() -> FunctionExpression {
+    return FunctionExpression(functionName: "trim", args: [self])
+  }
+
   func stringConcat(_ strings: [Expression]) -> FunctionExpression {
     return FunctionExpression(functionName: "string_concat", args: [self] + strings)
   }
@@ -773,20 +793,6 @@ public extension Expression {
     return FunctionExpression(functionName: "map_merge", args: [self] + maps)
   }
 
-  func mapSet(key: Expression, value: Sendable) -> FunctionExpression {
-    return FunctionExpression(
-      functionName: "map_set",
-      args: [self, key, Helper.sendableToExpr(value)]
-    )
-  }
-
-  func mapSet(key: String, value: Sendable) -> FunctionExpression {
-    return FunctionExpression(
-      functionName: "map_set",
-      args: [self, Helper.sendableToExpr(key), Helper.sendableToExpr(value)]
-    )
-  }
-
   // --- Added Aggregate Operations (on Expr) ---
 
   func countDistinct() -> AggregateFunction {
@@ -919,7 +925,7 @@ public extension Expression {
     return FunctionExpression(functionName: "timestamp_to_unix_seconds", args: [self])
   }
 
-  func timestampTruncate(granularity: TimeUnit) -> FunctionExpression {
+  func timestampTruncate(granularity: TimeGranularity) -> FunctionExpression {
     return FunctionExpression(
       functionName: "timestamp_trunc",
       args: [self, Helper.sendableToExpr(granularity.rawValue)]
@@ -1001,4 +1007,8 @@ public extension Expression {
     let exprs = [self] + values.map { Helper.sendableToExpr($0) }
     return FunctionExpression(functionName: "concat", args: exprs)
   }
+
+  func type() -> FunctionExpression {
+    return FunctionExpression(functionName: "type", args: [self])
+  }
 }

Firestore/Swift/Source/Stages.swift

@@ -26,7 +26,8 @@ import Foundation
 protocol Stage {
   var name: String { get }
   var bridge: StageBridge { get }
-  /// The `errorMessage` defaults to `nil`. Errors during stage construction are captured and thrown later when `execute()` is called.
+  /// The `errorMessage` defaults to `nil`. Errors during stage construction are captured and thrown
+  /// later when `execute()` is called.
   var errorMessage: String? { get }
 }
 

Firestore/Swift/Source/SwiftAPI/Pipeline/Expressions/Expression.swift

@@ -461,10 +461,35 @@ public protocol Expression: Sendable {
   /// - Returns: A new `FunctionExpression` representing the "arrayGet" operation.
   func arrayGet(_ offsetExpression: Expression) -> FunctionExpression
 
+  /// Creates an expression that returns the maximum element of an array.
+  ///
+  /// Assumes `self` evaluates to an array.
+  ///
+  /// ```swift
+  /// // Get the maximum value in the "scores" array.
+  /// Field("scores").arrayMaximum()
+  /// ```
+  ///
+  /// - Returns: A new `FunctionExpression` representing the maximum element of the array.
+  func arrayMaximum() -> FunctionExpression
+
+  /// Creates an expression that returns the minimum element of an array.
+  ///
+  /// Assumes `self` evaluates to an array.
+  ///
+  /// ```swift
+  /// // Get the minimum value in the "scores" array.
+  /// Field("scores").arrayMinimum()
+  /// ```
+  ///
+  /// - Returns: A new `FunctionExpression` representing the minimum element of the array.
+  func arrayMinimum() -> FunctionExpression
+
   /// Creates a `BooleanExpression` that returns `true` if this expression is greater
   /// than the given expression.
   ///
   /// - Parameter other: The expression to compare against.
+  /// - Returns: A `BooleanExpression` that can be used in `where` clauses.
   /// - Returns: A `BooleanExpression` that can be used in a where stage, together with other
   /// boolean expressions.
   func greaterThan(_ other: Expression) -> BooleanExpression
@@ -473,6 +498,7 @@ public protocol Expression: Sendable {
   /// than the given value.
   ///
   /// - Parameter other: The value to compare against.
+  /// - Returns: A `BooleanExpression` that can be used in `where` clauses.
   /// - Returns: A `BooleanExpression` that can be used in a where stage, together with other
   /// boolean expressions.
   func greaterThan(_ other: Sendable) -> BooleanExpression
@@ -481,6 +507,7 @@ public protocol Expression: Sendable {
   /// greater than or equal to the given expression.
   ///
   /// - Parameter other: The expression to compare against.
+  /// - Returns: A `BooleanExpression` that can be used in `where` clauses.
   /// - Returns: A `BooleanExpression` that can be used in a where stage, together with other
   /// boolean expressions.
   func greaterThanOrEqual(_ other: Expression) -> BooleanExpression
@@ -489,6 +516,7 @@ public protocol Expression: Sendable {
   /// greater than or equal to the given value.
   ///
   /// - Parameter other: The value to compare against.
+  /// - Returns: A `BooleanExpression` that can be used in `where` clauses.
   /// - Returns: A `BooleanExpression` that can be used in a where stage, together with other
   /// boolean expressions.
   func greaterThanOrEqual(_ other: Sendable) -> BooleanExpression
@@ -497,6 +525,7 @@ public protocol Expression: Sendable {
   /// than the given expression.
   ///
   /// - Parameter other: The expression to compare against.
+  /// - Returns: A `BooleanExpression` that can be used in `where` clauses.
   /// - Returns: A `BooleanExpression` that can be used in a where stage, together with other
   /// boolean expressions.
   func lessThan(_ other: Expression) -> BooleanExpression
@@ -505,6 +534,7 @@ public protocol Expression: Sendable {
   /// than the given value.
   ///
   /// - Parameter other: The value to compare against.
+  /// - Returns: A `BooleanExpression` that can be used in `where` clauses.
   /// - Returns: A `BooleanExpression` that can be used in a where stage, together with other
   /// boolean expressions.
   func lessThan(_ other: Sendable) -> BooleanExpression
@@ -681,6 +711,18 @@ public protocol Expression: Sendable {
   /// - Returns: A new `FunctionExpression` representing the joined string.
   func join(delimiter: String) -> FunctionExpression
 
+  /// Creates an expression that splits a string into an array of substrings based on a delimiter.
+  ///
+  /// - Parameter delimiter: The string to split on.
+  /// - Returns: A new `FunctionExpression` representing the array of substrings.
+  func split(delimiter: String) -> FunctionExpression
+
+  /// Creates an expression that splits a string into an array of substrings based on a delimiter.
+  ///
+  /// - Parameter delimiter: An expression that evaluates to a string or bytes to split on.
+  /// - Returns: A new `FunctionExpression` representing the array of substrings.
+  func split(delimiter: Expression) -> FunctionExpression
+
   /// Creates an expression that returns the length of a string.
   ///
   /// ```swift
@@ -886,6 +928,18 @@ public protocol Expression: Sendable {
   /// - Returns: A new `FunctionExpression` representing the uppercase string.
   func toUpper() -> FunctionExpression
 
+  /// Creates an expression that removes leading and trailing whitespace from a string.
+  ///
+  /// Assumes `self` evaluates to a string.
+  ///
+  /// ```swift
+  /// // Trim leading/trailing whitespace from the "comment" field.
+  /// Field("comment").trim()
+  /// ```
+  ///
+  /// - Returns: A new `FunctionExpression` representing the trimmed string.
+  func trim() -> FunctionExpression
+
   /// Creates an expression that removes leading and trailing occurrences of specified characters
   /// from a string (from `self`).
   /// Assumes `self` evaluates to a string, and `value` evaluates to a string.
@@ -961,8 +1015,8 @@ public protocol Expression: Sendable {
   /// - Returns: A new `FunctionExpression` representing the reversed string.
   func stringReverse() -> FunctionExpression
 
-  /// Creates an expression that calculates the length of this expression in bytes.
-  /// Assumes `self` evaluates to a string.
+  /// Creates an expression that calculates the length of this string or bytes expression in bytes.
+  /// Assumes `self` evaluates to a string or bytes.
   ///
   /// ```swift
   /// // Calculate the length of the "myString" field in bytes.
@@ -975,9 +1029,9 @@ public protocol Expression: Sendable {
   /// - Returns: A new `FunctionExpression` representing the length in bytes.
   func byteLength() -> FunctionExpression
 
-  /// Creates an expression that returns a substring of this expression using
+  /// Creates an expression that returns a substring of this expression (String or Bytes) using
   /// literal integers for position and optional length.
-  /// Indexing is 0-based. Assumes `self` evaluates to a string.
+  /// Indexing is 0-based. Assumes `self` evaluates to a string or bytes.
   ///
   /// ```swift
   /// // Get substring from index 5 with length 10
@@ -992,9 +1046,9 @@ public protocol Expression: Sendable {
   /// - Returns: A new `FunctionExpression` representing the substring.
   func substring(position: Int, length: Int?) -> FunctionExpression
 
-  /// Creates an expression that returns a substring of this expression using
+  /// Creates an expression that returns a substring of this expression (String or Bytes) using
   /// expressions for position and optional length.
-  /// Indexing is 0-based. Assumes `self` evaluates to a string, and parameters evaluate to
+  /// Indexing is 0-based. Assumes `self` evaluates to a string or bytes, and parameters evaluate to
   /// integers.
   ///
   /// ```swift
@@ -1080,34 +1134,6 @@ public protocol Expression: Sendable {
   /// - Returns: A new `FunctionExpression` representing the "map_merge" operation.
   func mapMerge(_ maps: [Expression]) -> FunctionExpression
 
-  /// Creates an expression that adds or updates a specified field in a map.
-  /// Assumes `self` evaluates to a Map, `key` evaluates to a string, and `value` can be
-  /// any type.
-  ///
-  /// ```swift
-  /// // Set a field using a key from another field
-  /// Field("config").mapSet(key: Field("keyName"), value: Field("keyValue"))
-  /// ```
-  ///
-  /// - Parameter key: An `Expression` (evaluating to a string) representing the key of
-  /// the field to set or update.
-  /// - Parameter value: The `Expression` representing the value to set for the field.
-  /// - Returns: A new `FunctionExpression` representing the map with the updated field.
-  func mapSet(key: Expression, value: Sendable) -> FunctionExpression
-
-  /// Creates an expression that adds or updates a specified field in a map.
-  /// Assumes `self` evaluates to a Map.
-  ///
-  /// ```swift
-  /// // Set the "status" field to "active" in the "order" map
-  /// Field("order").mapSet(key: "status", value: "active")
-  /// ```
-  ///
-  /// - Parameter key: The literal string key of the field to set or update.
-  /// - Parameter value: The `Sendable` literal value to set for the field.
-  /// - Returns: A new `FunctionExpression` representing the map with the updated field.
-  func mapSet(key: String, value: Sendable) -> FunctionExpression
-
   // MARK: Aggregations
 
   /// Creates an aggregation that counts the number of distinct values of this expression.
@@ -1429,19 +1455,23 @@ public protocol Expression: Sendable {
   /// Field("timestamp").timestampTruncate(granularity: .day)
   /// ```
   ///
-  /// - Parameter granularity: A `TimeUnit` enum representing the truncation unit.
+  /// - Parameter granularity: A `TimeGranularity` representing the truncation unit.
   /// - Returns: A new `FunctionExpression` representing the truncated timestamp.
-  func timestampTruncate(granularity: TimeUnit) -> FunctionExpression
+  func timestampTruncate(granularity: TimeGranularity) -> FunctionExpression
 
   /// Creates an expression that truncates a timestamp to a specified granularity.
-  /// Assumes `self` evaluates to a Timestamp, and `granularity` is a literal string.
+  /// Assumes `self` evaluates to a Timestamp.
   ///
   /// ```swift
   /// // Truncate "timestamp" field to the nearest day using a literal string.
   /// Field("timestamp").timestampTruncate(granularity: "day")
+  ///
+  /// // Truncate "timestamp" field to the nearest day using an expression.
+  /// Field("timestamp").timestampTruncate(granularity: Field("granularity_field"))
   /// ```
   ///
-  /// - Parameter granularity: A `Sendable` literal string specifying the truncation unit.
+  /// - Parameter granularity: A `Sendable` literal string or an `Expression` that evaluates to a
+  /// string, specifying the truncation unit.
   /// - Returns: A new `FunctionExpression` representing the truncated timestamp.
   func timestampTruncate(granularity: Sendable) -> FunctionExpression
 
@@ -1596,4 +1626,14 @@ public protocol Expression: Sendable {
   /// - Parameter values: The values to concatenate.
   /// - Returns: A new `FunctionExpression` representing the concatenated result.
   func concat(_ values: [Sendable]) -> FunctionExpression
+
+  /// Creates an expression that returns the type of the expression.
+  ///
+  /// ```swift
+  /// // Get the type of the "rating" field.
+  /// Field("rating").type()
+  /// ```
+  ///
+  /// - Returns: A new `FunctionExpression` representing the type of the expression as a string.
+  func type() -> FunctionExpression
 }

Firestore/Swift/Source/SwiftAPI/Pipeline/Pipeline.swift

@@ -103,6 +103,17 @@ public struct Pipeline: @unchecked Sendable {
     }
   }
 
+  /// Creates a new `Pipeline` instance in a faulted state.
+  ///
+  /// This function is used to propagate an error through the pipeline chain. When a stage
+  /// fails to initialize or if a preceding stage has already failed, this method is called
+  /// to create a new pipeline that holds the error message. The `stages` array is cleared,
+  /// and the `errorMessage` is set.
+  ///
+  /// The stored error is eventually thrown by the `execute()` method.
+  ///
+  /// - Parameter message: The error message to store in the pipeline.
+  /// - Returns: A new `Pipeline` instance with the specified error message.
   private func withError(_ message: String) -> Pipeline {
     return Pipeline(stages: [], db: db, errorMessage: message)
   }
@@ -127,7 +138,7 @@ public struct Pipeline: @unchecked Sendable {
   /// - Throws: An error if the pipeline execution fails on the backend.
   /// - Returns: A `Pipeline.Snapshot` containing the result of the pipeline execution.
   public func execute() async throws -> Pipeline.Snapshot {
-    // Check if any Error exist during Stage contruction
+    // Check if any errors occurred during stage construction.
     if let errorMessage = errorMessage {
       throw NSError(
         domain: "com.google.firebase.firestore",