-
Notifications
You must be signed in to change notification settings - Fork 51
Feat: add UseEmulator to the storage SDK #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AustinBenoit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a significant new feature to the Firebase Storage SDK: the ability to connect to a local Firebase Storage emulator. This enhancement is crucial for improving the developer experience by enabling local testing and development workflows, reducing reliance on live Firebase services, and potentially speeding up iteration cycles. The change involves adding a public method to configure the emulator's host and port. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for using the Firebase Storage emulator by introducing a UseEmulator method. The implementation is straightforward and includes corresponding documentation updates. My review focuses on improving the code quality and correctness. I've pointed out a syntax error in the XML documentation that would break doc generation and an indentation inconsistency. Addressing these points will improve the code's maintainability and correctness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but since we have a release coming up without the C++ change, it might make sense to wait until that is done before committing this.
Description
Add support for Firebase Storage emulator via
UseEmulator.Testing
Tested this manually via unity for Desktop, Android, iOS. See the photos below:
Type of Change
Place an
xthe applicable box: