Skip to content

Conversation

@AustinBenoit
Copy link

Description

Add support for Firebase Storage emulator via UseEmulator.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Tested this manually via unity for Desktop, Android, iOS. See the photos below:

image image image

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AustinBenoit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a significant new feature to the Firebase Storage SDK: the ability to connect to a local Firebase Storage emulator. This enhancement is crucial for improving the developer experience by enabling local testing and development workflows, reducing reliance on live Firebase services, and potentially speeding up iteration cycles. The change involves adding a public method to configure the emulator's host and port.

Highlights

  • Firebase Storage Emulator Support: Introduced a new UseEmulator method to the Firebase Storage SDK, allowing developers to configure the SDK to connect to a local Storage emulator instead of the default remote backend. This method should be invoked before any other operations on a new Storage instance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for using the Firebase Storage emulator by introducing a UseEmulator method. The implementation is straightforward and includes corresponding documentation updates. My review focuses on improving the code quality and correctness. I've pointed out a syntax error in the XML documentation that would break doc generation and an indentation inconsistency. Addressing these points will improve the code's maintainability and correctness.

Copy link
Collaborator

@a-maurice a-maurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but since we have a release coming up without the C++ change, it might make sense to wait until that is done before committing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants