Skip to content

Conversation

@pq
Copy link
Collaborator

@pq pq commented Nov 6, 2025

A jumping off point for a sendReport implementation.

Next step is to add params and do some experimenting w/ DTD.

You'll note that this handles error conditions a little differently than the other DTD interactions and I'm open to feedback. (In those cases we return futures that will blow up if interrogated. I'm not sure we want to do that here (or even if we'll ever ask?)) Dunno.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested a review from helin24 November 6, 2025 00:16
@pq
Copy link
Collaborator Author

pq commented Nov 6, 2025

/gemini

1 similar comment
@helin24
Copy link
Member

helin24 commented Nov 6, 2025

/gemini

@gemini-code-assist
Copy link

Thanks for the ping! I've received the /gemini command and will process the pull request.

@helin24
Copy link
Member

helin24 commented Nov 6, 2025

Hmmm I'm not sure if gemini is just taking a while or if something's wrong. BTW should this be moved to the Dart plugin?

@helin24
Copy link
Member

helin24 commented Nov 6, 2025

Otherwise this LGTM

@pq
Copy link
Collaborator Author

pq commented Nov 6, 2025

Ultimately, yeah, I do think this and the whole analytics reporting service should move to the Dart plugin. I don't want to gate it on that though. (Luckily it should be a simple move once the time comes.)

Copy link
Member

@helin24 helin24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the result handling structure; we can use that elsewhere if it's working well.

@helin24
Copy link
Member

helin24 commented Nov 6, 2025

Thanks for the ping! I've received the /gemini command and will process the pull request.

@gemini-code-assist this is taking a while - perhaps there is an issue with this PR since it was created before we enabled gemini?

@gemini-code-assist
Copy link

Thanks for checking in, @helin24! The /gemini command can sometimes take a little while to process, especially for larger pull requests. The creation date of the PR shouldn't cause any issues with the review process. I'm still working on it and will provide feedback as soon as it's ready.

@pq pq merged commit 2bf5db2 into flutter:main Nov 7, 2025
7 checks passed
@pq pq deleted the analytics_sendReport_v1 branch November 7, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants