-
Notifications
You must be signed in to change notification settings - Fork 197
Modularized bitset cpp #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Modularized bitset cpp #1050
Conversation
|
here is a proposal (to replace #1049) that relies only on the CPP directives. @jalvesz : I didn't look carefully to |
|
Thanks for this new approach @jvdp1. One question though, I didn't see the header file defining the default value of the internal define parameter. If so, one would be obliged to pass a flag even when building with a compiler that does support it, right? |
Sorry I forgot about it. I will add one, such that the default is the compilation of |
|
@jalvesz : I added a file However, I think that the file |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1050 +/- ##
==========================================
+ Coverage 25.12% 25.13% +0.01%
==========================================
Files 570 570
Lines 234201 234201
Branches 41277 41275 -2
==========================================
+ Hits 58838 58872 +34
+ Misses 175363 175329 -34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Based on #1031, #1033
Closes #1049
Here is a proposition to modularize
stdlibusingcppdirectives (instead offypp) based on this comment\cc: @eduardz1 @jalvesz @perazz