feat(cli): add detailed non-prod build environment check for Convex deploy (#28) #247
+15
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improved the
isNonProdBuildEnvironmentfunction and the related check insidedeploy.tsto provide clearer and more specific messages when a non-production environment is detected.Changes
isNonProdBuildEnvironment()inenvvars.tsto return a descriptive message instead of a boolean.deploy.tsto display that message when the CLI detects a non-production environment during deployment.Example Output
Detected VERCEL because the VERCEL env var is set, but VERCEL_ENV is "preview" instead of "production".
Detected a non-production build environment and "CONVEX_DEPLOY_KEY" for a production Convex deployment.
This is probably unintentional.
Closes
Fixes #28
Testing
Verified locally by simulating:
Thanks for maintaining this great project!
Excited to contribute to improving developer experience.