fix(convex-query-client): prevent crash when unsubscribing missing qu… #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have issues that when I use react query with other convex react hooks.
|
|
@salemkode in what situations does this happen? This is an invariant that I'd want to know if it was broken; are other query users removing these, are other clients allowed to remove these? I'd love to know how your'e seeing this, and to add a comment here with why this could already be gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(convex-query-client): prevent crash when unsubscribing missing query subscription
This fixes a
TypeError: Cannot read property 'unsubscribe' of undefinedthat occurred when a query was removed before its subscription was fully
established. We now safely check for the subscription before calling
unsubscribe().By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.