Metrics Product Docs #15375
Metrics Product Docs #15375
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 347.2kB (-1.48%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
Co-authored-by: Kyle a.k.a. TechSquidTV <git@techsquidtv.com>
Co-authored-by: Kyle a.k.a. TechSquidTV <git@techsquidtv.com>
coolguyzone
force-pushed
the
metrics-docs
branch
from
79a20ba to
ce3ac54
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| platform="javascript.wasm" | ||
| label="Wasm" | ||
| url="/platforms/javascript/guides/wasm/metrics/" | ||
| /> |
There was a problem hiding this comment.
Bug
The documentation links to /platforms/javascript/metrics/ and /platforms/javascript/guides/:guide/metrics/ paths, but these URLs are already redirected in redirects.js (lines 1080-1086) to /platforms/javascript/tracing/span-metrics/ which is a different feature. This means all the platform-specific metrics links (lines 22, 27, 32, 37, 42, 47, 52, 57, 62, 67, 72, 77, 82, 87, 92, 97, 102, 107, 112, 117, 122, 127, 132, 137, 142, 147, 152, 157, 162, 167, 172) will redirect users to span-metrics documentation instead of the intended Metrics feature documentation, breaking the documentation flow.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| /> | ||
| - <LinkWithPlatformIcon | ||
| platform="python.aws-lambda" | ||
| label="AWS Lambda" | ||
| url="/platforms/python/guides/aws-lambda/metrics/" | ||
| /> | ||
| - <LinkWithPlatformIcon | ||
| platform="python.gcp-functions" | ||
| label="Google Cloud Functions" | ||
| url="/platforms/python/guides/gcp-functions/metrics/" | ||
| /> |
There was a problem hiding this comment.
Bug: New getting-started guide links to non-existent JavaScript metrics documentation pages.
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
The new getting-started guide in docs/product/explore/metrics/getting-started/index.mdx includes links to platform-specific metrics documentation for JavaScript. However, the corresponding documentation pages for JavaScript platforms, such as /platforms/javascript/metrics/ and /platforms/javascript/guides/angular/metrics/, do not exist in the repository. This causes users attempting to set up Metrics with JavaScript/TypeScript SDKs to encounter 404 errors when clicking these links.
💡 Suggested Fix
Create the missing JavaScript platform-specific metrics documentation pages or remove/update the links in docs/product/explore/metrics/getting-started/index.mdx until the documentation is available.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: docs/product/explore/metrics/getting-started/index.mdx#L19-L218
Potential issue: The new getting-started guide in
`docs/product/explore/metrics/getting-started/index.mdx` includes links to
platform-specific metrics documentation for JavaScript. However, the corresponding
documentation pages for JavaScript platforms, such as `/platforms/javascript/metrics/`
and `/platforms/javascript/guides/angular/metrics/`, do not exist in the repository.
This causes users attempting to set up Metrics with JavaScript/TypeScript SDKs to
encounter 404 errors when clicking these links.
Did we get this right? 👍 / 👎 to inform future reviews.
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES