Skip to content

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Oct 23, 2025

Pass ignoreCSSAttributes with background-imgae to ignore background images when blockAllMedia is enabled. ignoreCSSAttributes was expanded in this PR so that it also works for inline styles.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.64 kB - -
@sentry/browser - with treeshaking flags 23.13 kB - -
@sentry/browser (incl. Tracing) 41.26 kB - -
@sentry/browser (incl. Tracing, Profiling) 45.54 kB - -
@sentry/browser (incl. Tracing, Replay) 79.74 kB +0.3% +236 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.43 kB +0.33% +227 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 84.44 kB +0.28% +232 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 96.61 kB +0.25% +232 B 🔺
@sentry/browser (incl. Feedback) 41.31 kB - -
@sentry/browser (incl. sendFeedback) 29.31 kB - -
@sentry/browser (incl. FeedbackAsync) 34.24 kB - -
@sentry/react 26.32 kB - -
@sentry/react (incl. Tracing) 43.24 kB - -
@sentry/vue 29.13 kB -0.01% -1 B 🔽
@sentry/vue (incl. Tracing) 43.05 kB - -
@sentry/svelte 24.65 kB - -
CDN Bundle 26.9 kB - -
CDN Bundle (incl. Tracing) 41.8 kB - -
CDN Bundle (incl. Tracing, Replay) 78.32 kB +0.32% +249 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 83.8 kB +0.29% +237 B 🔺
CDN Bundle - uncompressed 78.89 kB - -
CDN Bundle (incl. Tracing) - uncompressed 124.01 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 240.05 kB +0.36% +846 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 252.81 kB +0.34% +846 B 🔺
@sentry/nextjs (client) 45.36 kB - -
@sentry/sveltekit (client) 41.67 kB - -
@sentry/node-core 50.81 kB +0.01% +1 B 🔺
@sentry/node 157.88 kB +0.01% +1 B 🔺
@sentry/node - without tracing 92.69 kB +0.01% +1 B 🔺
@sentry/aws-serverless 106.42 kB +0.01% +3 B 🔺

View base workflow run

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,664 - 8,837 -2%
GET With Sentry 1,377 16% 1,275 +8%
GET With Sentry (error only) 6,073 70% 5,923 +3%
POST Baseline 1,183 - 1,153 +3%
POST With Sentry 512 43% 476 +8%
POST With Sentry (error only) 1,048 89% 1,018 +3%
MYSQL Baseline 3,325 - 3,212 +4%
MYSQL With Sentry 460 14% 366 +26%
MYSQL With Sentry (error only) 2,709 81% 2,570 +5%

View base workflow run

@billyvg billyvg marked this pull request as ready for review October 23, 2025 17:50
@billyvg billyvg requested a review from a team as a code owner October 23, 2025 17:50
@billyvg billyvg requested a review from chargome October 23, 2025 17:51
@billyvg billyvg force-pushed the billy/feat-replay-ignore-background-css-inline branch from 83a5467 to a6b7d3d Compare October 24, 2025 17:28
@billyvg
Copy link
Member Author

billyvg commented Oct 24, 2025

@sentry review

Pass `ignoreCSSAttributes` with `background-imgae` to ignore background images when `blockAllMedia` is enabled. `ignoreCSSAttributes` was expanded in [this PR](getsentry/rrweb#252) so that it also works for inline styles.
@billyvg billyvg force-pushed the billy/feat-replay-ignore-background-css-inline branch from a6b7d3d to c8413aa Compare November 5, 2025 17:23
@billyvg billyvg force-pushed the billy/feat-replay-ignore-background-css-inline branch from 1644a2f to 4be3838 Compare November 5, 2025 20:19
@billyvg billyvg merged commit 6360009 into develop Nov 5, 2025
380 of 383 checks passed
@billyvg billyvg deleted the billy/feat-replay-ignore-background-css-inline branch November 5, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants