Skip to content

fix(core): update client options to allow explicit undefined #18024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −4
Open

fix(core): update client options to allow explicit undefined #18024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/core/src/types-hoist/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export interface ClientOptions<TO extends BaseTransportOptions = BaseTransportOp
*
* @default undefined
*/
dsn?: string;
dsn?: string | undefined;

/**
* Sets the release. Release names are strings, but some formats are detected by Sentry and might be
Expand All @@ -88,7 +88,7 @@ export interface ClientOptions<TO extends BaseTransportOptions = BaseTransportOp
*
* @default undefined
*/
release?: string;
release?: string | undefined;

/**
* The current environment of your application (e.g. "production").
Expand All @@ -98,15 +98,15 @@ export interface ClientOptions<TO extends BaseTransportOptions = BaseTransportOp
*
* @default "production"
*/
environment?: string;
environment?: string | undefined;

/**
* Sets the distribution of the application. Distributions are used to disambiguate build or
* deployment variants of the same release of an application.
*
* @default undefined
*/
dist?: string;
dist?: string | undefined;

/**
* List of integrations that should be installed after SDK was initialized.
Expand Down