feat(node): Add maxCacheKeyLength to Redis integration (remove truncation)
#18045
+104
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
added
the
Integration: redis
s1gr1d
commented
Oct 28, 2025
Comment on lines
+34
to
+50
| describe('early returns', () => { | ||
| it.each([ | ||
| { desc: 'no args', cmd: 'get', args: [], response: 'test' }, | ||
| { desc: 'unsupported command', cmd: 'exists', args: ['key'], response: 'test' }, | ||
| { desc: 'no cache prefixes', cmd: 'get', args: ['key'], response: 'test', options: {} }, | ||
| { desc: 'non-matching prefix', cmd: 'get', args: ['key'], response: 'test', options: { cachePrefixes: ['c'] } }, | ||
| ])('should always set sentry.origin but return early when $desc', ({ cmd, args, response, options = {} }) => { | ||
| vi.clearAllMocks(); | ||
| Object.assign(_redisOptions, options); | ||
|
|
||
| cacheResponseHook(mockSpan, cmd, args, response); | ||
|
|
||
| expect(mockSpan.setAttribute).toHaveBeenCalledWith('sentry.origin', 'auto.db.otel.redis'); | ||
| expect(mockSpan.setAttributes).not.toHaveBeenCalled(); | ||
| expect(mockSpan.updateName).not.toHaveBeenCalled(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I added some general tests for the handler, as there were none for this behavior so far.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
JPeer264
approved these changes
Nov 4, 2025
| { desc: 'no cache prefixes', cmd: 'get', args: ['key'], response: 'test', options: {} }, | ||
| { desc: 'non-matching prefix', cmd: 'get', args: ['key'], response: 'test', options: { cachePrefixes: ['c'] } }, | ||
| ])('should always set sentry.origin but return early when $desc', ({ cmd, args, response, options = {} }) => { | ||
| vi.clearAllMocks(); |
There was a problem hiding this comment.
super-l: Maybe it is more future proof to move this into the afterEach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the automatic truncation of the span description. Now, all cache keys are set in the description.
part of #17389