feat(cli): add the ability to specify a custom keybinding/symbols file via the cli #2731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e via the cli Introduce `-k`,`--key-bindings`, `-s`, and `--key-symbols` arguments to allow the user from specifying a custom config files without having to change the global ones this change is meant to address github issue: gitui-org#2714
0x61nas
force-pushed
the
feat/custom-configs-path
branch
from
c678978 to
5a14779
Compare
cruessler
approved these changes
Oct 30, 2025
| Arg::new("key_symbols") | ||
| .help("Use a custom symbols file") | ||
| .short('s') | ||
| .long("key-symblos") |
There was a problem hiding this comment.
Typo: this should by key-symbols.
Comment on lines
+42
to
+46
| if !path.exists() { | ||
| return Err(anyhow!( | ||
| "The custom key bindings file dosen't exists" | ||
| )); | ||
| } |
There was a problem hiding this comment.
This check can be removed as KeysList::init calls File::open which will error if the file does not exist.
Comment on lines
+53
to
+57
| if !path.exists() { | ||
| return Err(anyhow!( | ||
| "The custom key symbols file dosen't exists" | ||
| )); | ||
| } |
There was a problem hiding this comment.
This check can be removed as KeysList::init calls File::open which will error if the file does not exist.
| "The custom key bindings file dosen't exists" | ||
| )); | ||
| } | ||
| KeysList::init(path.clone()) |
There was a problem hiding this comment.
What do you think about something like KeysList::init(key_bindings_path.unwrap_or(Self::get_config_file()?))? (Same below for symbols.)
cruessler
requested changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
-k,--key-bindings,-s, and--key-symbolsarguments to allow the user from specifying a custom config files without having to change the global onesThis Pull Request fixes/closes #2714.
It changes the following:
I followed the checklist:
make checkwithout errors