Skip to content

Conversation

@gillg
Copy link

@gillg gillg commented Oct 30, 2022

The curret IsWindowsService() method was inherited from the legacy .NET fwk and not compatible inside windows containers. We need to update it to be go x/sys compatible inside containers.

Fixes #56335

@gopherbot
Copy link
Contributor

This PR (HEAD: d0a68bb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/446535 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/446535.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alex Brainman:

Patch Set 1: Run-TryBot+1

(10 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/446535.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/446535.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/446535.
After addressing review feedback, remember to publish your drafts!

The current IsWindowsService() function was inherited from the legacy .NET
framework and not compatible inside windows containers. We need to update it
so it works inside containers.

References to: dotnet/runtime#52416
Fixes golang/go#56335
@gopherbot
Copy link
Contributor

Message from Guillaume Gill:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/446535.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: e0659b9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/446535 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Guillaume Gill:

Patch Set 1:

(9 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/446535.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants