-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat!: Address post-merge enterprise billing cost center review #3805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc: @alexandear |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3805 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 192 192
Lines 13896 13896
=======================================
Hits 12823 12823
Misses 884 884
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexandear
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Suggested a few renamings.
|
Thanks. Renamed. |
zyfy29
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thank you, @gjasny, @zyfy29, and @alexandear! |
BREAKING CHANGES: Various
EnterpriseServicestructs have been renamed for consistency.