HHH-19892 signature of Session.merge() accepting EntityGraph

[gavinking]

cc @dreab8 WDYT?

[Please describe here what your change is about]

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

https://hibernate.atlassian.net/browse/HHH-19892

[dreab8]

I think the change is correct, my only concern is that this is a API breaking change am I right?

I think you have also to fix the LoadGraphMergeTestcompilation errors

[gavinking]

my only concern is that this is a API breaking change am I right?

Yes, it's definitely the sort of change we're not to supposed to do in a minor, but this method is pretty new. In this case I guess I think it would cause worse disruption to wait until H8 to fix it. I highly doubt many people are using this feature yet or are even aware it exists. If we wait years to fix it, it's going to cause way more breakage when we do.

I think you have also to fix the LoadGraphMergeTest compilation errors

Yup, on it.

[gavinking]

I have not heard any objections to this. I pinged @sebersole a while back but he did not respond.

I'm going to assume that silence here indicates consent and go ahead and merge this.

But if anyone actually does object to this, please speak up so we can discuss it and revert if that is the consensus.

[sebersole]

Right, I was on PTO :)

I'm fine with the change.

[gavinking]

OK, good, phew :)

Thanks