PostgreSQL: Mutation query with Joined Inheritance for databases supporting Global Temporary issue with transactions #2733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or databases supporting Global Temporary issue with transactions Created a PostgreSQLCteMutationSelect that wraps JdbcSelect and change the original SQL string adding explicit cast to parameters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| addExplicitCastToParameters( | ||
| jdbcParameterBindings, | ||
| newSelect, | ||
| context.getSession().getSessionFactory().getMappingMetamodel().getTypeConfiguration() |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
|
Thanks @dreab8 I don't know why, but the test fails for MariaDB. I don't know if I want to add back this kind of parameter processing. We worked hard to remove it in the past. I will have a better look at it later, though. I'm working on some other things at the moment |
dreab8
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2412
Based on Vert.X team feedbacks the proposed change forces the explicit type cast of the parameters in the CTE select query.