Rename ConTextTab -> sap-rpt-1-oss #1832
Open
+15
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxSchambach
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c,
ngxson and
pcuenca
as code owners
Wauplin
reviewed
Nov 5, 2025
There was a problem hiding this comment.
Hi @MaxSchambach, changes looks good to me. Before merging this PR, could you address the comment + add sap-rpt-1-oss as library_name in https://huggingface.co/SAP/sap-rpt-1-oss ? Once that's done, I'll merge and make a release
| prettyLabel: "ConTextTab", | ||
| repoName: "ConTextTab", | ||
| repoUrl: "https://github.com/SAP-samples/contexttab", | ||
| "sap-rpt-1-oss": { |
There was a problem hiding this comment.
can you move the entry down in the mapping to keep alphabetical order? (between sample-factory and sapiens)
There was a problem hiding this comment.
👍 thanks! I've reordered and updated the library name in the repo.
There was a problem hiding this comment.
Anything else that needs resolving? I see some pipeline steps failing but am not sure if they are related
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The model and repo have been renamed. This PR adjusts the tag and snippets accordingly.