Remove non-utc trait impls and make InfluxDbWriteable fail-able #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't know core::error::Error would be a problem ... TIL
Better than the MSRV of 1.81 for core::error But I'd really like to use write! in proc-macros ...
Empty2k12
requested changes
Sep 11, 2025
| for wf in &writeable_fields { | ||
| if wf.is_time { | ||
| if time_field.is_some() { | ||
| panic!("multiple time fields found!"); |
There was a problem hiding this comment.
Prefer return Err(syn::Error::new(...)) or compile_error!?
There was a problem hiding this comment.
Prefer syn::Error, we have code that turns it into a compile error later: https://github.com/influxdb-rs/influxdb-rust/blob/main/influxdb_derive/src/lib.rs#L10
|
@Empty2k12 can this be merged? The panic you mentioned above was not introduced in this PR, so I'd argue it's not in scope here to remove it (eventhough it should be removed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #170. As a result of removing the
0-fallback and converting theFromimpls toTryFrom, I had to adjust theInfluxDbWriteabletrait and macro. Creating queries may now fail.Checklist
cargo fmt --allcargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features chrono,time,serde,derive,reqwest-client-rustls -- -D warningscargo doc2readme -p influxdb --expand-macrosAny unfinished work that warrants a separate issue captured in an issue with a TODO code comment