Skip to content

Conversation

@ethanglaser
Copy link
Member

No description provided.

@ethanglaser ethanglaser requested review from Copilot and removed request for ahuber21, dian-lun-lin and ibhati October 23, 2025 18:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the shared C++ examples to support multiple installation methods for the SVS library, specifically adding support for pip and conda packages alongside the existing tarball release method. The changes simplify the workflow when using pip/conda installations by automatically detecting installed packages and falling back to tarball download when needed.

Key changes:

  • Added automatic detection of system/conda/pip SVS installations before downloading tarball
  • Updated documentation to include installation and usage instructions for conda and pip methods
  • Simplified library linking by using CMake targets instead of manual library finding

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
examples/cpp/shared/README.md Added documentation for conda and pip installation methods with usage examples, reorganized content into three installation options
examples/cpp/shared/CMakeLists.txt Implemented automatic SVS package detection with fallback to tarball download, updated library linking to use CMake targets

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mihaic mihaic self-assigned this Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants